Re: [PATCH v4 24/24] integrity/powerpc: Support loading keys from pseries secvar

From
Andrew Donnellan <hidden>
Date
2023-01-25 00:45:35
Also in
linux-integrity, lkml
Reply to
Mimi Zohar, 2023-01-24
On Tue, 2023-01-24 at 10:14 -0500, Mimi Zohar wrote:
quoted
-       /* The following only applies for the edk2-compat backend.
*/
-       node = of_find_compatible_node(NULL, NULL, "ibm,edk2-
compat-v1");
-       if (!node)
+       len = secvar_ops->format(buf, 32);
"powerpc/secvar: Handle format string in the consumer"  defines
opal_secvar_format() for the object format "ibm,secvar-backend". 
Here
shouldn't it being returning the format for "ibm,edk2-compat-v1"?
opal_secvar_format() doesn't return "ibm,secvar-backend", it searches
for the device tree node named "ibm,secvar-backend", then reads and
returns the contents of the property "format" under that node.

The expected content of the format property is "ibm,edk2-compat-v1".

-- 
Andrew Donnellan    OzLabs, ADL Canberra
ajd@linux.ibm.com   IBM Australia Limited
Thread (52 messages) 52 messages, 8 authors, last reply 2023-02-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help