Re: [PATCH v4 21/24] powerpc/pseries: Pass PLPKS password on kexec

From
Andrew Donnellan <hidden>
Date
2023-01-24 04:40:42
Also in
linux-integrity, lkml
Reply to
Nicholas Piggin, 2023-01-24
On Tue, 2023-01-24 at 14:36 +1000, Nicholas Piggin wrote:
quoted
+       prop = of_find_property(of_chosen, "ibm,plpks-pw", &len);
+       if (prop) {
+               ospasswordlength = (u16)len;
+               ospassword = kzalloc(ospasswordlength, GFP_KERNEL);
+               if (!ospassword) {
+                       of_remove_property(of_chosen, prop);
+                       return -ENOMEM;
+               }
+               memcpy(ospassword, prop->value, len);
+               return of_remove_property(of_chosen, prop);
Why do you remove the property afterward?
Because otherwise the password will be sitting around in /proc/device-
tree for the world to go and read.

-- 
Andrew Donnellan    OzLabs, ADL Canberra
ajd@linux.ibm.com   IBM Australia Limited
Thread (52 messages) 52 messages, 8 authors, last reply 2023-02-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help