Thread (15 messages) 15 messages, 6 authors, 2022-12-08

Re: [PATCH 2/3] powerpc/book3e: remove #include <generated/utsrelease.h>

From: Masahiro Yamada <masahiroy@kernel.org>
Date: 2022-11-29 09:35:44
Also in: linux-arch, lkml

On Mon, Nov 28, 2022 at 7:59 AM Michael Ellerman [off-list ref] wrote:
Thomas Weißschuh [off-list ref] writes:
quoted
On 2022-11-26 07:36+0000, Christophe Leroy wrote:
quoted
Le 26/11/2022 à 06:10, Thomas Weißschuh a écrit :
quoted
Commit 7ad4bd887d27 ("powerpc/book3e: get rid of #include <generated/compile.h>")
removed the usage of the define UTS_VERSION but forgot to drop the
include.
What about:
arch/powerpc/platforms/52xx/efika.c
arch/powerpc/platforms/amigaone/setup.c
arch/powerpc/platforms/chrp/setup.c
arch/powerpc/platforms/powermac/bootx_init.c

I believe you can do a lot more than what you did in your series.
The commit messages are wrong.
They should have said UTS_RELEASE instead of UTS_VERSION.

Could the maintainers fix this up when applying?
I also changed it locally so it will be fixed for v2.
I'll take this patch, but not the others.

cheers

Okay, I applied 1/3 and 3/3 to the kbuild tree.




-- 
Best Regards
Masahiro Yamada
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help