Thread (15 messages) 15 messages, 6 authors, 2022-12-08

Re: [PATCH 3/3] init/version.c: remove #include <generated/utsversion.h>

From: Masahiro Yamada <masahiroy@kernel.org>
Date: 2022-11-26 22:25:39
Also in: lkml

On Sat, Nov 26, 2022 at 2:10 PM Thomas Weißschuh [off-list ref] wrote:
Commit 2df8220cc511 ("kbuild: build init/built-in.a just once") moved
the usage of the define UTS_VERSION to the file version-timestamp.c.
With s/UTS_VERSION/UTS_RELEASE/,


Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>
quoted hunk ↗ jump to hunk
version-timestamp.c in turn is included from version.c but already
includes utsversion.h itself properly.

The unneeded include of utsversion.h from version.c can be dropped.

Fixes: 2df8220cc511 ("kbuild: build init/built-in.a just once")
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 init/version.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/init/version.c b/init/version.c
index 01d4ab05f0ba..f117921811b4 100644
--- a/init/version.c
+++ b/init/version.c
@@ -15,7 +15,6 @@
 #include <linux/printk.h>
 #include <linux/uts.h>
 #include <linux/utsname.h>
-#include <generated/utsrelease.h>
 #include <linux/proc_ns.h>

 static int __init early_hostname(char *arg)
--
2.38.1

-- 
Best Regards
Masahiro Yamada
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help