Re: [PATCH 2/7] powerpc/85xx: Mark mpc85xx_ds_pic_init() as static
From: Christophe Leroy <hidden>
Date: 2022-10-16 17:00:05
Also in:
lkml
Hello, Le 16/10/2022 à 13:05, Pali Rohár a écrit :
Hello Christophe! Do you have any other comments for this patch series?
I'm AFK for two weeks, but as far as I remember I don't have any more comments.
On Monday 26 September 2022 11:47:06 Pali Rohár wrote:quoted
On Monday 26 September 2022 09:43:55 Christophe Leroy wrote:quoted
Le 19/08/2022 à 21:15, Pali Rohár a écrit :quoted
Function mpc85xx_ds_pic_init() is not used out of the mpc85xx_ds.c file. Signed-off-by: Pali Rohár <pali@kernel.org>This patch should be squashed into patch 1.No problem. Just to explain that I split those changes into different patches because they touch different files and different board code. And I thought that different things should be in different patches.quoted
quoted
--- arch/powerpc/platforms/85xx/mpc85xx_ds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/arch/powerpc/platforms/85xx/mpc85xx_ds.c b/arch/powerpc/platforms/85xx/mpc85xx_ds.c index f8d2c97f39bd..9a6d637ef54a 100644 --- a/arch/powerpc/platforms/85xx/mpc85xx_ds.c +++ b/arch/powerpc/platforms/85xx/mpc85xx_ds.c@@ -54,7 +54,7 @@ static void mpc85xx_8259_cascade(struct irq_desc *desc) } #endif /* CONFIG_PPC_I8259 */ -void __init mpc85xx_ds_pic_init(void) +static void __init mpc85xx_ds_pic_init(void) { struct mpic *mpic; #ifdef CONFIG_PPC_I8259