Re: [PATCH 7/7] powerpc: dts: turris1x.dts: Remove "fsl,P2020RDB-PC" compatible string
From: Christophe Leroy <hidden>
Date: 2022-09-26 10:11:54
Also in:
lkml
Le 19/08/2022 à 21:15, Pali Rohár a écrit :
"fsl,P2020RDB-PC" compatible string was present in Turris 1.x DTS file just because Linux kernel required it for proper detection of P2020 processor during boot. This was quite a hack as CZ,NIC Turris 1.x is not compatible with Freescale P2020-RDB-PC board. Now when kernel has generic unified support for boards with P2020 processors, there is no need to have this "hack" in turris1x.dts file. So remove incorrect "fsl,P2020RDB-PC" compatible string from turris1x.dts.
Oh, I thought it was not possible to modify DTSes.
If it is, can you have a common compatible to all p2020, for instance
"fsl,p2020', so that you can use it in patch 5 instead of
of_find_node_by_path("/cpus/PowerPC,P2020@0") ?
quoted hunk ↗ jump to hunk
Signed-off-by: Pali Rohár <pali@kernel.org> --- arch/powerpc/boot/dts/turris1x.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/arch/powerpc/boot/dts/turris1x.dts b/arch/powerpc/boot/dts/turris1x.dts index 12e08271e61f..69c38ed8a3a5 100644 --- a/arch/powerpc/boot/dts/turris1x.dts +++ b/arch/powerpc/boot/dts/turris1x.dts@@ -15,7 +15,7 @@ / { model = "Turris 1.x"; - compatible = "cznic,turris1x", "fsl,P2020RDB-PC"; /* fsl,P2020RDB-PC is required for booting Linux */ + compatible = "cznic,turris1x"; aliases { ethernet0 = &enet0;