Re: [PATCH v2 1/9] PCI/AER: Add pci_aer_clear_uncorrect_error_status() to PCI core

From
Zhuo Chen <hidden>
Date
2022-09-28 08:32:42
Also in
linux-pci, linux-scsi, lkml
Reply to
Sathyanarayanan Kuppuswamy, 2022-09-27

On 9/28/22 3:31 AM, Sathyanarayanan Kuppuswamy wrote:
Hi,

On 9/27/22 8:35 AM, Zhuo Chen wrote:
quoted
Sometimes we need to clear aer uncorrectable error status, so we add
Adding n actual use case will help.
quoted
pci_aer_clear_uncorrect_error_status() to PCI core.
If possible, try to avoid "we" usage in commit log. Just say "so add
pci_aer_clear_uncorrect_error_status() function"
quoted
Signed-off-by: Zhuo Chen <redacted>
---
  drivers/pci/pcie/aer.c | 16 ++++++++++++++++
  include/linux/aer.h    |  5 +++++
  2 files changed, 21 insertions(+)
diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
index e2d8a74f83c3..4e637121be23 100644
--- a/drivers/pci/pcie/aer.c
+++ b/drivers/pci/pcie/aer.c
@@ -286,6 +286,22 @@ void pci_aer_clear_fatal_status(struct pci_dev *dev)
  		pci_write_config_dword(dev, aer + PCI_ERR_UNCOR_STATUS, status);
  }
  
+int pci_aer_clear_uncorrect_error_status(struct pci_dev *dev)
+{
+	int aer = dev->aer_cap;
+	u32 status;
+
+	if (!pcie_aer_is_native(dev))
+		return -EIO;
+
+	pci_read_config_dword(dev, aer + PCI_ERR_UNCOR_STATUS, &status);
+	if (status)
+		pci_write_config_dword(dev, aer + PCI_ERR_UNCOR_STATUS, status);
Why not just write all '1' and clear it? Why read and write?
Hi Sathyanarayanan,

The current implementation and the previous implementation are all first read and then write to clear the status. Currently just be consistent with them:
 - aer_enable_rootport()
 - pci_aer_raw_clear_status()
 - pcibios_plat_dev_init() in arch/mips/pci/pci-octeon.c
 - commit fd3362cb73de ("PCI/AER: Squash aerdrv_core.c into aerdrv.c")
   pci_cleanup_aer_uncorrect_error_status
quoted
+
+	return 0;
+}
+EXPORT_SYMBOL_GPL(pci_aer_clear_uncorrect_error_status);
Add details about why you want to export in commit log.
Thanks,

I will add details and improve commit log in next version.
quoted
+
  /**
   * pci_aer_raw_clear_status - Clear AER error registers.
   * @dev: the PCI device
diff --git a/include/linux/aer.h b/include/linux/aer.h
index 97f64ba1b34a..154690c278cb 100644
--- a/include/linux/aer.h
+++ b/include/linux/aer.h
@@ -45,6 +45,7 @@ struct aer_capability_regs {
  int pci_enable_pcie_error_reporting(struct pci_dev *dev);
  int pci_disable_pcie_error_reporting(struct pci_dev *dev);
  int pci_aer_clear_nonfatal_status(struct pci_dev *dev);
+int pci_aer_clear_uncorrect_error_status(struct pci_dev *dev);
  void pci_save_aer_state(struct pci_dev *dev);
  void pci_restore_aer_state(struct pci_dev *dev);
  #else
@@ -60,6 +61,10 @@ static inline int pci_aer_clear_nonfatal_status(struct pci_dev *dev)
  {
  	return -EINVAL;
  }
+static inline int pci_aer_clear_uncorrect_error_status(struct pci_dev *dev)
+{
+	return -EINVAL;
+}
  static inline void pci_save_aer_state(struct pci_dev *dev) {}
  static inline void pci_restore_aer_state(struct pci_dev *dev) {}
  #endif
-- 
Thanks,
Zhuo Chen
Thread (19 messages) 19 messages, 3 authors, last reply 2022-09-28
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help