Re: [PATCH v2 11/14] powerpc/64s: Clear/restore caller gprs in syscall interrupt/return

On Thu, Aug 11, 2022 at 03:39:58PM +0000, Christophe Leroy wrote:

Le 11/08/2022 à 17:13, Segher Boessenkool a écrit :

quoted

Hi!

On Mon, Jul 25, 2022 at 04:31:11PM +1000, Rohan McLure wrote:

quoted

+	/*
+	 * Zero user registers to prevent influencing speculative execution
+	 * state of kernel code.
+	 */
+	NULLIFY_GPRS(5, 12)
+	NULLIFY_NVGPRS()

"Nullify" means "invalidate", which is not what this does or is for :-(

Would "Zeroise" be more appropriate ?

That is probably a good compromise, yes.  It obviously is a verb, its
meaning is clear and unamiguous, and there is precedent for it even :-)

Thanks,


Segher