Thread (30 messages) 30 messages, 22 authors, 2022-07-18

Re: [PATCH 6/6] i2c: Make remove callback return void

From: Peter Rosin <hidden>
Date: 2022-07-02 11:35:57
Also in: alsa-devel, chrome-platform, dri-devel, linux-mediatek, linux-staging

rg>, Robert Jones [off-list ref], George Joseph [off-list ref], Vincent Knecht [off-list ref], Robin van der Gracht [off-list ref], Randy Dunlap [off-list ref], linux-stm32@st-md-mailman.stormreply.com, Michael Tretter [off-list ref], Geert Uytterhoeven [off-list ref], Phong LE [off-list ref], Daniel Beer [off-list ref], Krzysztof Opasiak [off-list ref], Bjorn Andersson [off-list ref], linux-crypto@vger.kernel.org, Pengutronix Kernel Team [off-list ref], Heungjun Kim [off-list ref], Hans Verkuil [off-list ref], David Lin [off-list ref], Vladimir Oltean [off-list ref], David Rhodes [off-list ref], Claudiu Beznea [off-list ref], Jean-Baptiste Maneyrol [off-list ref], Alexandre Belloni [off-list ref], Dan Robertson [off-list ref], Martyn Welch <martyn.welch@collab
 ora.co.uk>, Jiri Slaby [off-list ref], devicetree@vger.kernel.org, David Airlie [off-list ref], Jon Nettleton [off-list ref], Srinivas Pandruvada [off-list ref], Marco Felsch [off-list ref], Wim Van Sebroeck [off-list ref], Sebastian Reichel [off-list ref], Max Filippov [off-list ref], "Lad, Prabhakar" [off-list ref], Thierry Reding [off-list ref], linux-i2c@vger.kernel.org, Martiros Shakhzadyan [off-list ref], Guenter Roeck [off-list ref], Matthias Schwarzott [off-list ref], Sylwester Nawrocki [off-list ref], Eric Dumazet [off-list ref], =?UTF-8?Q?Marek_Beh=c3=ban?= [off-list ref], Saranya Gopal [off-list ref], Lars-Peter Clausen [off-list ref], Corey Minyard [off-list ref], Evgeny Novikov [off-list ref], Frank Rowand [off-list ref], Bartosz Golaszewski [off-list ref], Manivannan Sadhasivam [off-list ref], Pierre-Lo
 uis Bossart [off-list ref], M
inghao Chi [off-list ref], linux-clk@vger.kernel.org, Nathan Chancellor [off-list ref], MyungJoo Ham [off-list ref], Charles Gorand [off-list ref], Jagan Teki [off-list ref], Vijendar Mukunda [off-list ref], Miguel Ojeda [off-list ref], Kyungmin Park [off-list ref], Tianshu Qiu [off-list ref], Martin Donnelly [off-list ref], Woojung Huh [off-list ref], Rudolf Marek [off-list ref], Charles Keepax [off-list ref], linux-watchdog@vger.kernel.org, Michael Hennerich [off-list ref], Ido Schimmel [off-list ref], acpi4asus-user@lists.sourceforge.net, Simon Trimmer [off-list ref], Ricard Wanderlof [off-list ref], Rikard Falkeborn [off-list ref], Alex Deucher [off-list ref], Jiri Valek - 2N [off-list ref], linux-rpi-kernel@lists.infradead.org, Biju Das [off-list ref], Wayne 
 Chang [off-list ref], Chen-Yu Tsai [off-list ref], Sing-Han Chen [off-list ref], linux-arm-kernel@lists.infradead.org, =?UTF-8?Q?Niklas_S=c3=b6derlund?= [off-list ref], Hans de Goede [off-list ref], Stephen Boyd [off-list ref], Maslov Dmitry [off-list ref], linux-gpio@vger.kernel.org, Jens Frederich [off-list ref], Douglas Anderson [off-list ref], linux-media@vger.kernel.org, UNGLinuxDriver@microchip.com, Paul Kocialkowski [off-list ref], Jarkko Sakkinen [off-list ref], linux-usb@vger.kernel.org, Jacopo Mondi [off-list ref], Maxime Coquelin [off-list ref], CGEL ZTE [off-list ref], Colin Leroy [off-list ref], platform-driver-x86@vger.kernel.org, linux-integrity@vger.kernel.org, Kevin Tsai [off-list ref], =?UTF-8?Q?Pali_Roh=c3=a1r?= [off-list ref], Jonathan Cameron [off-list ref], Heiner Kallweit [off-list ref], Daniel Palmer <da
 niel@0x0f.com>, Arec Kao [off-list ref], Crt Mo
ri [off-list ref], Jose Cazarin [off-list ref], Neil Armstrong [off-list ref], linux-iio@vger.kernel.org, Tom Rix [off-list ref], Michael Turquette [off-list ref], Peter Senna Tschudin [off-list ref], Benjamin Mugnier [off-list ref], =?UTF-8?Q?Nuno_S=c3=a1?= [off-list ref], Jan-Simon Moeller [off-list ref], Wei Yongjun [off-list ref], Laurent Pinchart [off-list ref], Andrzej Hajda [off-list ref], Nikita Travkin [off-list ref], Jeremy Kerr [off-list ref], Jasmin Jessich [off-list ref], Sam Ravnborg [off-list ref], Kevin Cernekee [off-list ref], Alyssa Rosenzweig [off-list ref], linux-rtc@vger.kernel.org, Daniel Thompson [off-list ref], Florian Fainelli [off-list ref], Lucas Tanure [off-list ref], Stefan Mavrodiev [off-list ref], Masahiro Yamada [off-list ref], Sylvain Petinot <s
 ylvain.petinot@foss.st.com>, netdev@vger.kernel.org, Kieran Bingham [off-list ref], Jernej Skrabec [off-list ref], Xin Ji [off-list ref], Seven Lee [off-list ref], Matt Ranostay [off-list ref], Broadcom internal kernel review list [off-list ref], Adrien Grassein [off-list ref], Yang Yingliang [off-list ref], chrome-platform@lists.linux.dev, Mats Randgaard [off-list ref], Paolo Abeni [off-list ref], Alexey Dobriyan [off-list ref], Joel Stanley [off-list ref], linux-input@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Lyude Paul [off-list ref], Kees Cook [off-list ref], =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= [off-list ref], Jonas Karlman [off-list ref], Yang Li [off-list ref], Tim Harvey [off-list ref], Jiri Kosina [off-list ref], Akinobu Mita [off-list ref], Mark Gross [off-list ref], Richard F
 itzgerald [off-list ref], Mark Brown <bro
onie@kernel.org>, wengjianfeng [off-list ref], Maxime Ripard [off-list ref], Sven Peter [off-list ref], Martin Kepplinger [off-list ref], openipmi-developer@lists.sourceforge.net, Mauro Carvalho Chehab [off-list ref], Benson Leung [off-list ref], "Daniel W. S. Almeida" [off-list ref], Chiranjeevi Rapolu [off-list ref], Alessandro Zummo [off-list ref], linux-hwmon@vger.kernel.org, Felipe Balbi [off-list ref], Stephan Gerhold [off-list ref], Support Opensource [off-list ref], Alexandru Ardelean [off-list ref], Dmitry Torokhov [off-list ref], Marc Hulsman [off-list ref], Corentin Chary [off-list ref], Stephen Kitt [off-list ref], Daniel Scally [off-list ref], linux-fbdev@vger.kernel.org, Andrey Ryabinin [off-list ref], Arnd Bergmann [off-list ref], Kirill Shilimanov [off-list ref], Sakari Ailus <sakari.ailus@l
 inux.intel.com>, patches@opensource.cirrus.com, Zheng Yongjun [off-list ref], Alejandro Tafalla [off-list ref], "David S. Miller" [off-list ref], Arnaud Ferraris [off-list ref], Hector Martin [off-list ref], Vignesh Raghavendra [off-list ref], Nick Dyer [off-list ref], Greg Kroah-Hartman [off-list ref], Tony Lindgren [off-list ref], Alexandre Torgue [off-list ref], Takashi Iwai [off-list ref], Paul Cercueil [off-list ref], George McCollister [off-list ref], Mac Chiang [off-list ref], Antoniu Miclaus [off-list ref], Alexander Potapenko [off-list ref], linux-staging@lists.linux.dev, Adam Ford [off-list ref], Peter Huewe [off-list ref], Vincenzo Frascino [off-list ref], Lee Jones [off-list ref], linux-mtd@lists.infradead.org, Alexey Khoroshilov [off-list ref], Marek Vasut [off-list ref], Yizhuo <yzhai003@
 ucr.edu>, alsa-devel@alsa-project.org, Dmitry Rokosov
 [off-list ref], Eric Piel [off-list ref], Herbert Xu [off-list ref], Tobias Schrammm [off-list ref], Richard Weinberger [off-list ref], Tomasz Duszynski [off-list ref], Janusz Krzysztofik [off-list ref], Russell King [off-list ref], linux-pwm@vger.kernel.org, Jason Gunthorpe [off-list ref], Thomas Zimmermann [off-list ref], Bastien Nocera [off-list ref], Jingoo Han [off-list ref], Jakub Kicinski [off-list ref], Vivien Didelot [off-list ref], Shawn Tu [off-list ref], Leon Luo [off-list ref], Yan Lei [off-list ref], Akihiro Tsukada [off-list ref], Tudor Ambarus [off-list ref], Oliver Graute [off-list ref], Alistair Francis [off-list ref], Dongliang Mu [off-list ref], =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= [off-list ref], Eduardo Valentin [off-list ref], Rui Miguel Silva <rmfrf
 s@gmail.com>, Michael Srba [off-list ref], Rob Herring [off-list ref], linux-mediatek@lists.infradead.org, Fabio Estevam [off-list ref], Matthias Brugger [off-list ref], kasan-dev@googlegroups.com, "Paul J. Murphy" [off-list ref], Nicola Lunghi [off-list ref], Daniele Alessandrelli [off-list ref], Dmitry Vyukov [off-list ref], Ramesh Shanmugasundaram [off-list ref], Liam Girdwood [off-list ref], Juerg Haefliger [off-list ref], Oder Chiou [off-list ref], Shengjiu Wang [off-list ref], Nicolas Ferre [off-list ref], Robert Foss [off-list ref], Krzysztof Kozlowski [off-list ref], Daniel Vetter [off-list ref], =?UTF-8?Q?Alvin_=c5=a0ipraga?= [off-list ref], Luca Ceresoli [off-list ref], =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= [off-list ref], Johannes Berg [off-list ref], Colin Ian King <colin.king@in
 tel.com>, Maximilian Luz [off-list ref], H
elge Deller [off-list ref], Lucas Stach [off-list ref]
Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org
Sender: "Linuxppc-dev" [off-list ref]

2022-06-28 at 16:03, Uwe Kleine-König wrote:
From: Uwe Kleine-König <redacted>

The value returned by an i2c driver's remove function is mostly ignored.
(Only an error message is printed if the value is non-zero that the
error is ignored.)

So change the prototype of the remove function to return no value. This
way driver authors are not tempted to assume that passing an error to
the upper layer is a good idea. All drivers are adapted accordingly.
There is no intended change of behaviour, all callbacks were prepared to
return 0 before.

Signed-off-by: Uwe Kleine-König <redacted>
For drivers I'm involved in, namely:
 drivers/i2c/muxes/i2c-mux-ltc4306.c                       | 4 +---
 drivers/i2c/muxes/i2c-mux-pca9541.c                       | 3 +--
 drivers/i2c/muxes/i2c-mux-pca954x.c                       | 3 +--
 sound/soc/codecs/max9860.c                                | 3 +--
Acked-by: Peter Rosin <redacted>

Cheers,
Peter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help