Re: [PATCH 6/6] i2c: Make remove callback return void
From: Jeremy Kerr <jk@codeconstruct.com.au>
Date: 2022-06-29 07:31:23
Also in:
chrome-platform, dri-devel, linux-mediatek, linux-staging
.org>, Robert Jones [off-list ref], George Joseph [off-list ref], Vincent Knecht [off-list ref], Robin van der Gracht [off-list ref], Randy Dunlap [off-list ref], linux-stm32@st-md-mailman.stormreply.com, Michael Tretter [off-list ref], Geert Uytterhoeven [off-list ref], Phong LE [off-list ref], Daniel Beer [off-list ref], Krzysztof Opasiak [off-list ref], Bjorn Andersson [off-list ref], linux-crypto@vger.kernel.org, Pengutronix Kernel Team [off-list ref], Heungjun Kim [off-list ref], Hans Verkuil [off-list ref], David Lin [off-list ref], Vladimir Oltean [off-list ref], David Rhodes [off-list ref], Claudiu Beznea [off-list ref], Jean-Baptiste Maneyrol [off-list ref], Alexandre Belloni [off-list ref], Dan Robertson [off-list ref], Martyn Welch <martyn.welch@coll abora.co.uk>, Jiri Slaby [off-list ref], devicetree@vger.kernel.org, David Airlie [off-list ref], Jon Nettleton [off-list ref], Srinivas Pandruvada [off-list ref], Marco Felsch [off-list ref], Wim Van Sebroeck [off-list ref], Sebastian Reichel [off-list ref], Max Filippov [off-list ref], "Lad, Prabhakar" [off-list ref], Thierry Reding [off-list ref], linux-i2c@vger.kernel.org, Martiros Shakhzadyan [off-list ref], Guenter Roeck [off-list ref], Matthias Schwarzott [off-list ref], Sylwester Nawrocki [off-list ref], Eric Dumazet [off-list ref], Marek =?ISO-8859-1?Q?Beh�n?= [off-list ref], Saranya Gopal [off-list ref], Lars-Peter Clausen [off-list ref], Corey Minyard [off-list ref], Evgeny Novikov [off-list ref], Frank Rowand [off-list ref], Bartosz Golaszewski [off-list ref], Manivannan Sadhasivam [off-list ref], Pierr e-Louis Bossart <pierre-louis.bossart@linux.intel.com
, Minghao Chi [off-list ref], linux-clk@vger.kernel.org, Nathan Chancellor [off-list ref], MyungJoo Ham [off-list ref], Charles Gorand [off-list ref], Jagan Teki [off-list ref], Vijendar Mukunda [off-list ref], Miguel Ojeda [off-list ref], Kyungmin Park [off-list ref], Tianshu Qiu [off-list ref], Martin Donnelly [off-list ref], Woojung Huh [off-list ref], Rudolf Marek [off-list ref], Charles Keepax [off-list ref], linux-watchdog@vger.kernel.org, Michael Hennerich [off-list ref], Ido Schimmel [off-list ref], acpi4asus-user@lists.sourceforge.net, Simon Trimmer [off-list ref], Ricard Wanderlof [off-list ref], Rikard Falkeborn [off-list ref], Alex Deucher [off-list ref], Jiri Valek - 2N [off-list ref], linux-rpi-kernel@lists.infradead.org, Biju Das [off-list ref], Wa
yne Chang [off-list ref], Chen-Yu Tsai [off-list ref], Sing-Han Chen [off-list ref], linux-arm-kernel@lists.infradead.org, Niklas =?ISO-8859-1?Q?S�derlund?= [off-list ref], Hans de Goede [off-list ref], Stephen Boyd [off-list ref], Maslov Dmitry [off-list ref], linux-gpio@vger.kernel.org, Jens Frederich [off-list ref], Douglas Anderson [off-list ref], linux-media@vger.kernel.org, "David S. Miller" [off-list ref], Paul Kocialkowski [off-list ref], Jarkko Sakkinen [off-list ref], linux-usb@vger.kernel.org, Jacopo Mondi [off-list ref], Maxime Coquelin [off-list ref], CGEL ZTE [off-list ref], Colin Leroy [off-list ref], platform-driver-x86@vger.kernel.org, linux-integrity@vger.kernel.org, Kevin Tsai [off-list ref], Pali =?ISO-8859-1?Q?Roh�r?= [off-list ref], Jonathan Cameron [off-list ref], Heiner Kallweit [off-list ref] , Daniel Palmer [off-list ref], Arec Kao <arec.kao @intel.com>, Crt Mori [off-list ref], Jose Cazarin [off-list ref], Neil Armstrong [off-list ref], linux-iio@vger.kernel.org, Tom Rix [off-list ref], Michael Turquette [off-list ref], Peter Senna Tschudin [off-list ref], Benjamin Mugnier [off-list ref], Nuno =?ISO-8859-1?Q?S�?= [off-list ref], Jan-Simon Moeller [off-list ref], Wei Yongjun [off-list ref], Laurent Pinchart [off-list ref], Andrzej Hajda [off-list ref], Nikita Travkin [off-list ref], Jasmin Jessich [off-list ref], Sam Ravnborg [off-list ref], Kevin Cernekee [off-list ref], Alyssa Rosenzweig [off-list ref], linux-rtc@vger.kernel.org, Daniel Thompson [off-list ref], Florian Fainelli [off-list ref], Lucas Tanure [off-list ref], Stefan Mavrodiev [off-list ref], Masahiro Yamada [off-list ref], Sylvain Petinot <sylvain.petinot@fos s.st.com>, netdev@vger.kernel.org, Kieran Bingham [off-list ref], Jernej Skrabec [off-list ref], Xin Ji [off-list ref], Seven Lee [off-list ref], Matt Ranostay [off-list ref], Broadcom internal kernel review list [off-list ref], Adrien Grassein [off-list ref], Yang Yingliang [off-list ref], chrome-platform@lists.linux.dev, Mats Randgaard [off-list ref], Paolo Abeni [off-list ref], Alexey Dobriyan [off-list ref], Joel Stanley [off-list ref], linux-input@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Lyude Paul [off-list ref], Kees Cook [off-list ref], Uwe =?ISO-8859-1?Q?Kleine-K�nig?= [off-list ref], Jonas Karlman [off-list ref], Yang Li [off-list ref], Tim Harvey [off-list ref], Jiri Kosina [off-list ref], Akinobu Mita [off-list ref], Mark Gross [off-list ref], Richard Fitzgerald <rf@op ensource.cirrus.com>, Mark Brown [off-list ref] , wengjianfeng [off-list ref], Maxime Ripard [off-list ref], Sven Peter [off-list ref], Martin Kepplinger [off-list ref], openipmi-developer@lists.sourceforge.net, Mauro Carvalho Chehab [off-list ref], Benson Leung [off-list ref], "Daniel W. S. Almeida" [off-list ref], Chiranjeevi Rapolu [off-list ref], Alessandro Zummo [off-list ref], linux-hwmon@vger.kernel.org, Felipe Balbi [off-list ref], Stephan Gerhold [off-list ref], Support Opensource [off-list ref], Alexandru Ardelean [off-list ref], Dmitry Torokhov [off-list ref], Marc Hulsman [off-list ref], Corentin Chary [off-list ref], Stephen Kitt [off-list ref], Daniel Scally [off-list ref], linux-fbdev@vger.kernel.org, Andrey Ryabinin [off-list ref], Arnd Bergmann [off-list ref], Kirill Shilimanov [off-list ref], Sakari Ailus [off-list ref], patches@opensource.cirrus.com, Zheng Yongjun [off-list ref], Alejandro Tafalla [off-list ref], Peter Rosin [off-list ref], Arnaud Ferraris [off-list ref], Hector Martin [off-list ref], Vignesh Raghavendra [off-list ref], Nick Dyer [off-list ref], Greg Kroah-Hartman [off-list ref], Tony Lindgren [off-list ref], Alexandre Torgue [off-list ref], Takashi Iwai [off-list ref], Paul Cercueil [off-list ref], George McCollister [off-list ref], Mac Chiang [off-list ref], Antoniu Miclaus [off-list ref], Alexander Potapenko [off-list ref], linux-staging@lists.linux.dev, Adam Ford [off-list ref], Peter Huewe [off-list ref], UNGLinuxDriver@microchip.com, Lee Jones [off-list ref], linux-mtd@lists.infradead.org, Alexey Khoroshilov [off-list ref], Marek Vasut [off-list ref], Yizhuo [off-list ref], alsa-devel@alsa-project.org, Vinc enzo Frascino [off-list ref], Eric Piel [off-list ref], Herbert Xu [off-list ref], Tobias Schrammm [off-list ref], Richard Weinberger [off-list ref], Tomasz Duszynski [off-list ref], Janusz Krzysztofik [off-list ref], Russell King [off-list ref], linux-pwm@vger.kernel.org, Jason Gunthorpe [off-list ref], Thomas Zimmermann [off-list ref], Bastien Nocera [off-list ref], Jingoo Han [off-list ref], Jakub Kicinski [off-list ref], Vivien Didelot [off-list ref], Shawn Tu [off-list ref], Leon Luo [off-list ref], Yan Lei [off-list ref], Akihiro Tsukada [off-list ref], Tudor Ambarus [off-list ref], Dmitry Rokosov [off-list ref], Oliver Graute [off-list ref], Alistair Francis [off-list ref], Dongliang Mu [off-list ref], Jonathan =?ISO-8859-1?Q?Neusch�fer?= [off-list ref], Eduardo Valentin [off-list ref], Rui Miguel Silva [off-list ref], Michael Srba [off-list ref], Rob Herring [off-list ref], linux-mediatek@lists.infradead.org, Fabio Estevam [off-list ref], Matthias Brugger [off-list ref], kasan-dev@googlegroups.com, "Paul J. Murphy" [off-list ref], Nicola Lunghi [off-list ref], Daniele Alessandrelli [off-list ref], Dmitry Vyukov [off-list ref], Ramesh Shanmugasundaram [off-list ref], Liam Girdwood [off-list ref], Juerg Haefliger [off-list ref], Oder Chiou [off-list ref], Shengjiu Wang [off-list ref], Nicolas Ferre [off-list ref], Robert Foss [off-list ref], Krzysztof Kozlowski [off-list ref], Daniel Vetter [off-list ref], Alvin =?UTF-8?Q?Šipraga?= [off-list ref], Luca Ceresoli [off-list ref], =?ISO-8859-1?Q?Jos�_Exp�sito?= [off-list ref], Johannes Berg [off-list ref], Colin Ian King <colin .king@intel.com>, Maximilian Luz <luzmaximilian@gmail .com>, Helge Deller [off-list ref], Lucas Stach [off-list ref] Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" [off-list ref] Hi Uwe, Looks good - just one minor change for the mctp-i2c driver, but only worthwhile if you end up re-rolling this series for other reasons:
quoted hunk ↗ jump to hunk
-static int mctp_i2c_remove(struct i2c_client *client) +static void mctp_i2c_remove(struct i2c_client *client) { struct mctp_i2c_client *mcli = i2c_get_clientdata(client); struct mctp_i2c_dev *midev = NULL, *tmp = NULL;@@ -1000,7 +1000,6 @@ static int mctp_i2c_remove(struct i2c_client *client)mctp_i2c_free_client(mcli); mutex_unlock(&driver_clients_lock); /* Callers ignore return code */ - return 0; }
The comment there no longer makes much sense, I'd suggest removing that too. Either way: Reviewed-by: Jeremy Kerr <jk@codeconstruct.com.au> Cheers, Jeremy