Thread (15 messages) 15 messages, 4 authors, 2022-06-15

Re: 回复: [PATCH 2/2] uio:powerpc:mpc85xx: l2-cache-sram uio driver implementation

From: Christophe Leroy <hidden>
Date: 2022-06-14 07:12:29
Also in: lkml


Le 14/06/2022 à 08:34, Greg KH a écrit :
On Tue, Jun 14, 2022 at 06:09:35AM +0000, Wenhu Wang wrote:
quoted
quoted
Odd indentation, did you use checkpatch.pl on your patch?
Actually, I checked with the scripts, and there was no warning here.
I also checked in text editors and vim, if I translate tab with 4 spaces,
the "vma/mem" areas in the 5 lines were aligned.
Tabs in Linux are always 8 spaces wide.
See 
https://docs.kernel.org/process/coding-style.html?highlight=coding+style#indentation

Tabs are 8 characters, and thus indentations are also 8 characters. 
There are heretic movements that try to make indentations 4 (or even 2!) 
characters deep, and that is akin to trying to define the value of PI to 
be 3.

Christophe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help