On Fri, May 20, 2022 at 03:52:01PM -0400, Waiman Long wrote:

On 5/20/22 04:36, Maninder Singh wrote:

...

quoted

-		sprint_symbol(sym, addr);
+		sprint_symbol(sym, KSYM_SYMBOL_LEN, addr);

Instead of hardcoding KSYM_SYMBOL_LEN everywhere, will it better to hide it
like this:

        extern int __sprint_symbol(char *buffer, size_t size, unsigned long
address);
        #define sprint_symbol(buf, addr)        __sprint_symbol(buf,
sizeof(buf), addr)

Or you can use sizeof(buf) directly instead of KSYM_SYMBOL_LEN.

This assumes that buf is defined as char [], which might be not always the
case. If you are going with the macro, than ARRAY_SIZE() seems appropriate
to perform a check against the above mentioned constraint.


-- 
With Best Regards,
Andy Shevchenko