Thread (11 messages) 11 messages, 6 authors, 2022-06-15

Re: [PATCH 0/5] kallsyms: make kallsym APIs more safe with scnprintf

From: Christoph Hellwig <hch@infradead.org>
Date: 2022-05-22 06:09:18
Also in: linux-fsdevel, linux-modules, linux-s390, linux-scsi, lkml

On Fri, May 20, 2022 at 02:06:56PM +0530, Maninder Singh wrote:
kallsyms functionality depends on KSYM_NAME_LEN directly.
but if user passed array length lesser than it, sprintf
can cause issues of buffer overflow attack.

So changing *sprint* and *lookup* APIs in this patch set
to have buffer size as an argument and replacing sprintf with
scnprintf.
This is still a pretty horrible API.  Passing something like
a struct seq_buf seems like the much better API here.  Also with
the amount of arguments and by reference passing it might be worth
to pass them as a structure while you're at it.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help