Re: [PATCH 15/30] bus: brcmstb_gisb: Clean-up panic/die notifiers
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Date: 2022-05-17 15:33:42
Also in:
kexec, linux-alpha, linux-edac, linux-hyperv, linux-leds, linux-mips, linux-pm, linux-remoteproc, linux-s390, linux-tegra, linux-um, lkml, netdev, rcu, sparclinux, xen-devel
On 10/05/2022 12:28, Petr Mladek wrote:
[...] IMHO, the check of the @self parameter was the proper solution. "gisb_die_notifier" list uses @val from enum die_val. "gisb_panic_notifier" list uses @val from enum panic_notifier_val. These are unrelated types. It might easily break when someone defines the same constant also in enum die_val. Best Regards, Petr
OK Petr, I'll drop this idea for V2 - will just remove the useless header / prototype then. (CC Florian) Cheers, Guilherme