On Tue, May 10, 2022 at 08:46:41PM +1000, Nicholas Piggin wrote:
Excerpts from Ricardo Neri's message of May 6, 2022 10:00 am:
quoted
Prepare hardlockup_panic_setup() to handle a comma-separated list of
options. Thus, it can continue parsing its own command-line options while
ignoring parameters that are relevant only to specific implementations of
the hardlockup detector. Such implementations may use an early_param to
parse their own options.
It can't really handle comma separated list though, until the next
patch. nmi_watchdog=panic,0 does not make sense, so you lost error
handling of that.
Yes that is true. All possible combinations need to be checked.
And is it kosher to double handle options like this? I'm sure it
happens but it's ugly.
Would you consider just add a new option for x86 and avoid changing
this? Less code and patches.
Sure, I can not modify this code and add a x86-specific command-line
option.
Thanks and BR,
Ricardo