Re: [PATCH v6 13/29] iommu/amd: Compose MSI messages for NMI irqs in non-IR format

From
Thomas Gleixner <hidden>
Date
2022-05-06 21:32:01
Also in
linux-iommu, lkml
Reply to
Ricardo Neri, 2022-05-05
On Thu, May 05 2022 at 16:59, Ricardo Neri wrote:
+	 *
+	 * Also, NMIs do not have an associated vector. No need for cleanup.
They have a vector and what the heck is this cleanup comment for here?
There is nothing cleanup alike anywhere near.

Adding confusing comments is worse than adding no comments at all.

Thanks,

        tglx
Thread (69 messages) 69 messages, 3 authors, last reply 2022-05-20
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help