Thread (4 messages) 4 messages, 2 authors, 2022-03-30

Re: [PATCH v2] ftrace: Make ftrace_graph_is_dead() a static branch

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2022-03-30 20:19:58
Also in: lkml

On Wed, 30 Mar 2022 06:55:26 +0000
Christophe Leroy [off-list ref] wrote:
quoted
Small nit. Please order the includes in "upside-down x-mas tree" fashion:

#include <linux/jump_label.h>
#include <linux/suspend.h>
#include <linux/ftrace.h>
#include <linux/slab.h>
  
That's the first time I get such a request. Usually people request 
#includes to be in alphabetical order so when I see a file that has 
headers in alphabetical order I try to not break it, but here that was 
not the case so I put it at the end of the list.
This is something that Ingo Molnar started back in 2009 or so. And I do
find it easier on the eyes ;-)  I may be the only one today trying to keep
it (albeit poorly).

It's not a hard requirement, but I find it makes the code look more like
art, which it is :-D
I'll send v3
Thanks,

-- Steve
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help