Thread (4 messages) 4 messages, 2 authors, 2022-03-30

Re: [PATCH v2] ftrace: Make ftrace_graph_is_dead() a static branch

From: Christophe Leroy <hidden>
Date: 2022-03-30 06:55:34
Also in: lkml


Le 30/03/2022 à 04:07, Steven Rostedt a écrit :
On Fri, 25 Mar 2022 09:03:08 +0100
Christophe Leroy [off-list ref] wrote:
quoted
--- a/kernel/trace/fgraph.c
+++ b/kernel/trace/fgraph.c
@@ -10,6 +10,7 @@
  #include <linux/suspend.h>
  #include <linux/ftrace.h>
  #include <linux/slab.h>
+#include <linux/jump_label.h>
  
Small nit. Please order the includes in "upside-down x-mas tree" fashion:

#include <linux/jump_label.h>
#include <linux/suspend.h>
#include <linux/ftrace.h>
#include <linux/slab.h>
That's the first time I get such a request. Usually people request 
#includes to be in alphabetical order so when I see a file that has 
headers in alphabetical order I try to not break it, but here that was 
not the case so I put it at the end of the list.

I'll send v3

Thanks
Christophe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help