Re: [RFC PATCH 1/3] objtool: Move common code to utils.c
From: Miroslav Benes <mbenes@suse.cz>
Date: 2022-03-23 18:02:58
Also in:
lkml
From: Miroslav Benes <mbenes@suse.cz>
Date: 2022-03-23 18:02:58
Also in:
lkml
+#define sym_for_each_insn(file, sym, insn) \ + for (insn = find_insn(file, sym->sec, sym->offset); \ + insn && &insn->list != &file->insn_list && \ + insn->sec == sym->sec && \ + insn->offset < sym->offset + sym->len; \ + insn = list_next_entry(insn, list)) + +#endif /* UTILS_H */
Since you include <objtool/utils.h> in check.c, you can remove the definition of sym_for_each_insn() macro from check.c as well. I wonder if it would make sense to move all these helper functions to utils.c and utils.h. Might be connected to what Josh wrote about his work on objtool interface. Regards Miroslav