Re: [PATCH] powerpc: dts: t1040rdb: fix ports names for Seville Ethernet switch
From: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: 2021-12-30 13:00:10
Also in:
linux-devicetree, lkml
On Thu, Dec 30, 2021 at 01:43:28PM +0300, Maxim Kiselev wrote:
Fix network interface names for the switch ports according to labels
that are written on the front panel of the board. They start from ETH3
and end at ETH10.
Fixes: e69eb0824d8c ("powerpc: dts: t1040rdb: add ports for Seville
Ethernet switch")A Fixes: tag should not wrap on multiple lines.
Signed-off-by: Maxim Kiselev <redacted> Reviewed-by: Maxim Kochetkov <redacted> ---
Sadly I'm not able to confirm or disprove this change right now, because my T1040RDB has a bad DDR memory stick, it seems, so it just randomly hangs. But I'm pretty sure the Ethernet ports were properly mapped out when I tested them. Do you have the T1040RDB or the T1040D4RDB? Because the front panel of my T1040RDB looks like this: +---------------------------------------------------------------------+ | | | +-------+-------+ +-------+-------+-------+-------+ | | | UART0 | ETH1 | | ETH4 | ETH6 | ETH8 | ETH10 | | | +-------+-------+-------+-------+-------+-------+-------+-------+ | | | UART1 | ETH0 | ETH2 | ETH3 | ETH5 | ETH7 | ETH9 | ETH11 | | +--+-------+-------+-------+-------+-------+-------+-------+-------+--+
quoted hunk ↗ jump to hunk
arch/powerpc/boot/dts/fsl/t1040rdb.dts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)diff --git a/arch/powerpc/boot/dts/fsl/t1040rdb.dts b/arch/powerpc/boot/dts/fsl/t1040rdb.dts index af0c8a6f56138..b6733e7e65805 100644 --- a/arch/powerpc/boot/dts/fsl/t1040rdb.dts +++ b/arch/powerpc/boot/dts/fsl/t1040rdb.dts@@ -119,7 +119,7 @@ &seville_port0 { managed = "in-band-status"; phy-handle = <&phy_qsgmii_0>; phy-mode = "qsgmii"; - label = "ETH5"; + label = "ETH3"; status = "okay"; };@@ -135,7 +135,7 @@ &seville_port2 { managed = "in-band-status"; phy-handle = <&phy_qsgmii_2>; phy-mode = "qsgmii"; - label = "ETH7"; + label = "ETH5"; status = "okay"; };@@ -151,7 +151,7 @@ &seville_port4 { managed = "in-band-status"; phy-handle = <&phy_qsgmii_4>; phy-mode = "qsgmii"; - label = "ETH9"; + label = "ETH7"; status = "okay"; };@@ -167,7 +167,7 @@ &seville_port6 { managed = "in-band-status"; phy-handle = <&phy_qsgmii_6>; phy-mode = "qsgmii"; - label = "ETH11"; + label = "ETH9"; status = "okay"; };-- 2.32.0