Re: [patch V2 14/23] PCI/MSI: Make msix_update_entries() smarter
From: Bjorn Helgaas <helgaas@kernel.org>
Date: 2021-12-07 20:57:41
Also in:
ath11k, linux-hyperv, linux-mips, linux-pci, lkml, sparclinux, xen-devel
On Mon, Dec 06, 2021 at 11:27:46PM +0100, Thomas Gleixner wrote:
No need to walk the descriptors and check for each one whether the entries pointer function argument is NULL. Do it once. Signed-off-by: Thomas Gleixner <redacted> Tested-by: Juergen Gross <jgross@suse.com> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
quoted hunk ↗ jump to hunk
--- drivers/pci/msi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)--- a/drivers/pci/msi.c +++ b/drivers/pci/msi.c@@ -642,8 +642,8 @@ static void msix_update_entries(struct p { struct msi_desc *entry; - for_each_pci_msi_entry(entry, dev) { - if (entries) { + if (entries) { + for_each_pci_msi_entry(entry, dev) { entries->vector = entry->irq; entries++; }