Re: [PATCH v1 06/10] asm-generic: Refactor dereference_[kernel]_function_descriptor()
From: Arnd Bergmann <arnd@arndb.de>
Date: 2021-10-13 11:34:55
Also in:
linux-arch, linux-mm, lkml
From: Arnd Bergmann <arnd@arndb.de>
Date: 2021-10-13 11:34:55
Also in:
linux-arch, linux-mm, lkml
On Wed, Oct 13, 2021 at 1:20 PM Christophe Leroy [off-list ref] wrote:
Le 13/10/2021 à 09:02, Kees Cook a écrit :quoted
On Mon, Oct 11, 2021 at 05:25:33PM +0200, Christophe Leroy wrote:quoted
dereference_function_descriptor() and dereference_kernel_function_descriptor() are identical on the three architectures implementing them. Make it common. Signed-off-by: Christophe Leroy <redacted> --- arch/ia64/include/asm/sections.h | 19 ------------------- arch/parisc/include/asm/sections.h | 9 --------- arch/parisc/kernel/process.c | 21 --------------------- arch/powerpc/include/asm/sections.h | 23 ----------------------- include/asm-generic/sections.h | 18 ++++++++++++++++++ 5 files changed, 18 insertions(+), 72 deletions(-)A diffstat to love. :) Reviewed-by: Kees Cook <redacted>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Unless somebody minds, I will make them out of line as suggested by Helge in he's comment to patch 4. Allthough there is no spectacular size reduction, the functions are not worth being inlined as they are not used in critical pathes.
Sounds good to me.
Arnd