Re: [PATCH 0/2] powerpc/perf: Add instruction and data address registers to extended regs

On 02-Sep-2021, at 1:04 PM, kajoljain [off-list ref] wrote:



On 6/20/21 8:15 PM, Athira Rajeev wrote:

quoted

Patch set adds PMU registers namely Sampled Instruction Address Register
(SIAR) and Sampled Data Address Register (SDAR) as part of extended regs
in PowerPC. These registers provides the instruction/data address and
adding these to extended regs helps in debug purposes.

Patch 1/2 adds SIAR and SDAR as part of the extended regs mask.
Patch 2/2 includes perf tools side changes to add the SPRs to
sample_reg_mask to use with -I? option.

Athira Rajeev (2):
 powerpc/perf: Expose instruction and data address registers as part of
   extended regs
 tools/perf: Add perf tools support to expose instruction and data
   address registers as part of extended regs

Patchset looks good to me.

Reviewed-By: kajol Jain<redacted>

Hi Arnaldo,

Requesting for your review on this patchset.

Thanks
Athira

Thanks,
Kajol Jain

quoted

arch/powerpc/include/uapi/asm/perf_regs.h       | 12 +++++++-----
arch/powerpc/perf/perf_regs.c                   |  4 ++++
tools/arch/powerpc/include/uapi/asm/perf_regs.h | 12 +++++++-----
tools/perf/arch/powerpc/include/perf_regs.h     |  2 ++
tools/perf/arch/powerpc/util/perf_regs.c        |  2 ++
5 files changed, 22 insertions(+), 10 deletions(-)