Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has()

[PATCH v3 0/8] Implement generic cc_platform_has() helper function · Tom Lendacky <thomas.lendacky@amd.com> · 2021-09-08
[PATCH v3 1/8] x86/ioremap: Selectively build arch override encryption functions · Tom Lendacky <thomas.lendacky@amd.com> · 2021-09-08
[PATCH v3 2/8] mm: Introduce a function to check for confidential computing features · Tom Lendacky <thomas.lendacky@amd.com> · 2021-09-08
Re: [PATCH v3 2/8] mm: Introduce a function to check for confidential computing features · Christophe Leroy <hidden> · 2021-09-09
Re: [PATCH v3 2/8] mm: Introduce a function to check for confidential computing features · Borislav Petkov <bp@alien8.de> · 2021-09-10
[PATCH v3 3/8] x86/sev: Add an x86 version of cc_platform_has() · Tom Lendacky <thomas.lendacky@amd.com> · 2021-09-08
Re: [PATCH v3 3/8] x86/sev: Add an x86 version of cc_platform_has() · Borislav Petkov <bp@alien8.de> · 2021-09-11
[PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has() · Tom Lendacky <thomas.lendacky@amd.com> · 2021-09-08
Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has() · Christophe Leroy <hidden> · 2021-09-09
Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has() · Borislav Petkov <bp@alien8.de> · 2021-09-14
Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has() · Christophe Leroy <hidden> · 2021-09-14
Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has() · Borislav Petkov <bp@alien8.de> · 2021-09-14
Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has() · Michael Ellerman <mpe@ellerman.id.au> · 2021-09-15
Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has() · Borislav Petkov <bp@alien8.de> · 2021-09-15
Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has() · Christophe Leroy <hidden> · 2021-09-15
Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has() · Borislav Petkov <bp@alien8.de> · 2021-09-15
Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has() · Christoph Hellwig <hch@infradead.org> · 2021-09-16
Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has() · Michael Ellerman <mpe@ellerman.id.au> · 2021-09-16
[PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has() · Tom Lendacky <thomas.lendacky@amd.com> · 2021-09-08
Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has() · Borislav Petkov <bp@alien8.de> · 2021-09-14
Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has() · Kirill A. Shutemov <hidden> · 2021-09-21
Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has() · Tom Lendacky <thomas.lendacky@amd.com> · 2021-09-21
Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has() · Borislav Petkov <bp@alien8.de> · 2021-09-21
Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has() · Kirill A. Shutemov <hidden> · 2021-09-21
Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has() · Borislav Petkov <bp@alien8.de> · 2021-09-21
Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has() · Kirill A. Shutemov <hidden> · 2021-09-21
Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has() · Tom Lendacky <thomas.lendacky@amd.com> · 2021-09-21
Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has() · Kirill A. Shutemov <hidden> · 2021-09-21
Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has() · Tom Lendacky <thomas.lendacky@amd.com> · 2021-09-22
Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has() · Kirill A. Shutemov <hidden> · 2021-09-22
Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has() · Borislav Petkov <bp@alien8.de> · 2021-09-22
Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has() · Kirill A. Shutemov <hidden> · 2021-09-22
Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has() · Borislav Petkov <bp@alien8.de> · 2021-09-23
Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has() · Kirill A. Shutemov <hidden> · 2021-09-24
Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has() · Borislav Petkov <bp@alien8.de> · 2021-09-24
Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has() · Tom Lendacky <thomas.lendacky@amd.com> · 2021-09-24
[PATCH v3 6/8] x86/sev: Replace occurrences of sev_active() with cc_platform_has() · Tom Lendacky <thomas.lendacky@amd.com> · 2021-09-08
[PATCH v3 7/8] x86/sev: Replace occurrences of sev_es_active() with cc_platform_has() · Tom Lendacky <thomas.lendacky@amd.com> · 2021-09-08
[PATCH v3 8/8] treewide: Replace the use of mem_encrypt_active() with cc_platform_has() · Tom Lendacky <thomas.lendacky@amd.com> · 2021-09-08
Re: [PATCH v3 8/8] treewide: Replace the use of mem_encrypt_active() with cc_platform_has() · Christophe Leroy <hidden> · 2021-09-09
Re: [PATCH v3 8/8] treewide: Replace the use of mem_encrypt_active() with cc_platform_has() · Tom Lendacky <thomas.lendacky@amd.com> · 2021-09-09
Re: [PATCH v3 0/8] Implement generic cc_platform_has() helper function · Christian Borntraeger <hidden> · 2021-09-09
Re: [PATCH v3 0/8] Implement generic cc_platform_has() helper function · Tom Lendacky <thomas.lendacky@amd.com> · 2021-09-09
Re: [PATCH v3 0/8] Implement generic cc_platform_has() helper function · Borislav Petkov <bp@alien8.de> · 2021-09-15
Re: [PATCH v3 0/8] Implement generic cc_platform_has() helper function · "Kuppuswamy, Sathyanarayanan" <sathyanarayanan.kuppuswamy@linux.intel.com> · 2021-09-15
Re: [PATCH v3 0/8] Implement generic cc_platform_has() helper function · Borislav Petkov <bp@alien8.de> · 2021-09-16
Re: [PATCH v3 0/8] Implement generic cc_platform_has() helper function · "Kuppuswamy, Sathyanarayanan" <sathyanarayanan.kuppuswamy@linux.intel.com> · 2021-09-16

From: Christoph Hellwig <hch@infradead.org>
Date: 2021-09-16 07:37:21
Also in: amd-gfx, kexec, kvm, linux-efi, linux-fsdevel, linux-iommu, linux-s390, lkml, platform-driver-x86

On Wed, Sep 15, 2021 at 07:18:34PM +0200, Christophe Leroy wrote:

Could you please provide more explicit explanation why inlining such an
helper is considered as bad practice and messy ?

Because now we get architectures to all subly differ.  Look at the mess
for ioremap and the ioremap* variant.

The only good reason to allow for inlines if if they are used in a hot
path.  Which cc_platform_has is not, especially not on powerpc.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help