Re: [PATCH 06/11] x86/sev: Replace occurrences of sev_es_active() with prot_guest_has()

From: Joerg Roedel <joro@8bytes.org>
Date: 2021-08-02 10:45:29
Also in: amd-gfx, dri-devel, kvm, linux-efi, linux-fsdevel, linux-iommu, linux-s390, lkml, platform-driver-x86
Reply to: Tom Lendacky, 2021-07-27

On Tue, Jul 27, 2021 at 05:26:09PM -0500, Tom Lendacky wrote:

quoted hunk ↗ jump to hunk

@@ -48,7 +47,7 @@ static void sme_sev_setup_real_mode(struct trampoline_header *th)
 	if (prot_guest_has(PATTR_HOST_MEM_ENCRYPT))
 		th->flags |= TH_FLAGS_SME_ACTIVE;
 
-	if (sev_es_active()) {
+	if (prot_guest_has(PATTR_GUEST_PROT_STATE)) {
 		/*
 		 * Skip the call to verify_cpu() in secondary_startup_64 as it
 		 * will cause #VC exceptions when the AP can't handle them yet.

Not sure how TDX will handle AP booting, are you sure it needs this
special setup as well? Otherwise a check for SEV-ES would be better
instead of the generic PATTR_GUEST_PROT_STATE.

Regards,

Joerg

Tom Lendacky · 2021-07-27
[PATCH 01/11] mm: Introduce a function to check for virtualization protection features · Tom Lendacky · 2021-07-27
Re: [PATCH 01/11] mm: Introduce a function to check for virtualization protection features · Christoph Hellwig · 2021-07-28
Re: [PATCH 01/11] mm: Introduce a function to check for virtualization protection features · Borislav Petkov · 2021-07-28
Re: [PATCH 01/11] mm: Introduce a function to check for virtualization protection features · Joerg Roedel · 2021-08-02
Re: [PATCH 01/11] mm: Introduce a function to check for virtualization protection features · Kuppuswamy, Sathyanarayanan · 2021-08-11
Re: [PATCH 01/11] mm: Introduce a function to check for virtualization protection features · Tom Lendacky · 2021-08-11
[PATCH 02/11] x86/sev: Add an x86 version of prot_guest_has() · Tom Lendacky · 2021-07-27
Re: [PATCH 02/11] x86/sev: Add an x86 version of prot_guest_has() · Christoph Hellwig · 2021-07-28
Re: [PATCH 02/11] x86/sev: Add an x86 version of prot_guest_has() · Tom Lendacky · 2021-07-29
Re: [PATCH 02/11] x86/sev: Add an x86 version of prot_guest_has() · Joerg Roedel · 2021-08-02
[PATCH 03/11] powerpc/pseries/svm: Add a powerpc version of prot_guest_has() · Tom Lendacky · 2021-07-27
[PATCH 04/11] x86/sme: Replace occurrences of sme_active() with prot_guest_has() · Tom Lendacky · 2021-07-27
Re: [PATCH 04/11] x86/sme: Replace occurrences of sme_active() with prot_guest_has() · Joerg Roedel · 2021-08-02
[PATCH 05/11] x86/sev: Replace occurrences of sev_active() with prot_guest_has() · Tom Lendacky · 2021-07-27
Re: [PATCH 05/11] x86/sev: Replace occurrences of sev_active() with prot_guest_has() · Joerg Roedel · 2021-08-02
[PATCH 07/11] treewide: Replace the use of mem_encrypt_active() with prot_guest_has() · Tom Lendacky · 2021-07-27
Re: [PATCH 07/11] treewide: Replace the use of mem_encrypt_active() with prot_guest_has() · Sean Christopherson · 2021-07-30
Re: [PATCH 07/11] treewide: Replace the use of mem_encrypt_active() with prot_guest_has() · Tom Lendacky · 2021-08-09
Re: [PATCH 07/11] treewide: Replace the use of mem_encrypt_active() with prot_guest_has() · Christophe Leroy · 2021-08-02
Re: [PATCH 07/11] treewide: Replace the use of mem_encrypt_active() with prot_guest_has() · Tom Lendacky · 2021-08-09
Re: [PATCH 07/11] treewide: Replace the use of mem_encrypt_active() with prot_guest_has() · Kuppuswamy, Sathyanarayanan · 2021-08-10
Re: [PATCH 07/11] treewide: Replace the use of mem_encrypt_active() with prot_guest_has() · Tom Lendacky · 2021-08-10
Re: [PATCH 07/11] treewide: Replace the use of mem_encrypt_active() with prot_guest_has() · Kuppuswamy, Sathyanarayanan · 2021-08-10
Re: [PATCH 07/11] treewide: Replace the use of mem_encrypt_active() with prot_guest_has() · Kirill A. Shutemov · 2021-08-11
Re: [PATCH 07/11] treewide: Replace the use of mem_encrypt_active() with prot_guest_has() · Tom Lendacky · 2021-08-11
Re: [PATCH 07/11] treewide: Replace the use of mem_encrypt_active() with prot_guest_has() · Kirill A. Shutemov · 2021-08-12
Re: [PATCH 07/11] treewide: Replace the use of mem_encrypt_active() with prot_guest_has() · Tom Lendacky · 2021-08-13
Re: [PATCH 07/11] treewide: Replace the use of mem_encrypt_active() with prot_guest_has() · Tom Lendacky · 2021-08-13
[PATCH 06/11] x86/sev: Replace occurrences of sev_es_active() with prot_guest_has() · Tom Lendacky · 2021-07-27
Re: [PATCH 06/11] x86/sev: Replace occurrences of sev_es_active() with prot_guest_has() · Joerg Roedel · 2021-08-02
Re: [PATCH 06/11] x86/sev: Replace occurrences of sev_es_active() with prot_guest_has() · Tom Lendacky · 2021-08-09
Re: [PATCH 06/11] x86/sev: Replace occurrences of sev_es_active() with prot_guest_has() · Kuppuswamy, Sathyanarayanan · 2021-08-09
[PATCH 08/11] mm: Remove the now unused mem_encrypt_active() function · Tom Lendacky · 2021-07-27
Re: [PATCH 08/11] mm: Remove the now unused mem_encrypt_active() function · Joerg Roedel · 2021-08-02
[PATCH 09/11] x86/sev: Remove the now unused mem_encrypt_active() function · Tom Lendacky · 2021-07-27
Re: [PATCH 09/11] x86/sev: Remove the now unused mem_encrypt_active() function · Joerg Roedel · 2021-08-02
[PATCH 10/11] powerpc/pseries/svm: Remove the now unused mem_encrypt_active() function · Tom Lendacky · 2021-07-27
[PATCH 11/11] s390/mm: Remove the now unused mem_encrypt_active() function · Tom Lendacky · 2021-07-27
Tom Lendacky · 2021-07-27
Christian König · 2021-07-28
Kuppuswamy, Sathyanarayanan · 2021-08-09
Tom Lendacky · 2021-08-09
View all 43 messages

`h`	back out one level
`j`	next message in thread / next series-diff position
`k`	previous message in thread / previous series-diff position
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help