Re: [PATCH v2 3/4] powerpc: wii.dts: Expose the OTP on this platform
From: Segher Boessenkool <hidden>
Date: 2021-07-03 16:02:41
Also in:
linux-devicetree, lkml
On Fri, Jul 02, 2021 at 08:56:31AM +0000, Jonathan Neuschäfer wrote:
On Thu, Jul 01, 2021 at 09:56:55PM +0200, Emmanuel Gil Peyrot wrote:quoted
On Sat, Jun 26, 2021 at 11:34:01PM +0000, Jonathan Neuschäfer wrote:quoted
On Wed, May 19, 2021 at 11:50:43AM +0200, Emmanuel Gil Peyrot wrote:[...]quoted
quoted
quoted
+ otp@d8001ec { + compatible = "nintendo,hollywood-otp"; + reg = <0x0d8001ec 0x8>;The OTP registers overlap with the previous node, control@d800100. Not sure what's the best way to structure the devicetree in this case, maybe something roughly like the following (untested, unverified):[snip] I couldn’t get this to work, but additionally it looks like it should start 0x100 earlier and contain pic1@d800030 and gpio@d8000c0, given https://wiibrew.org/wiki/Hardware/Hollywood_Registers Would it make sense, for the time being, to reduce the size of this control@d800100 device to the single register currently being used by arch/powerpc/platforms/embedded6xx/wii.c (0xd800194, used to reboot the system) and leave the refactor of restart + OTP + PIC + GPIO for a future series?Makes sense to me!
There is no benefit to pretending there is a "control" bus (there is no such thing), it only gets in the way. Segher