Re: [RFC 1/4] drivers/nvdimm: Add perf interface to expose nvdimm performance stats

On 5/14/21 5:17 PM, Peter Zijlstra wrote:

On Thu, May 13, 2021 at 05:56:14PM +0530, kajoljain wrote:

quoted

But yes the current read/add/del functions are not adding value. We
could  add an arch/platform specific function which could handle the
capturing of the counter data and do the rest of the operation here,
is this approach better?

Right; have your register_nvdimm_pmu() set pmu->{add,del,read} to
nd_pmu->{add,del,read} directly, don't bother with these intermediates.
Also you can WARN_ON_ONCE() if any of them are NULL and fail
registration at that point.

Hi Peter,
    I will make all required changes and send next version of this patchset soon.

Thanks,
Kajol Jain