Thread (9 messages) 9 messages, 2 authors, 2021-05-17

Re: [RFC 1/4] drivers/nvdimm: Add perf interface to expose nvdimm performance stats

flat view

From: Peter Zijlstra <peterz@infradead.org>
Date: 2021-05-14 11:47:31
Also in: lkml

On Thu, May 13, 2021 at 05:56:14PM +0530, kajoljain wrote:
But yes the current read/add/del functions are not adding value. We
could  add an arch/platform specific function which could handle the
capturing of the counter data and do the rest of the operation here,
is this approach better?
Right; have your register_nvdimm_pmu() set pmu->{add,del,read} to
nd_pmu->{add,del,read} directly, don't bother with these intermediates.
Also you can WARN_ON_ONCE() if any of them are NULL and fail
registration at that point.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help