Re: [PATCH 11/18] iommu/fsl_pamu: remove the snoop_id field

From
Christoph Hellwig <hch@lst.de>
Date
2021-04-01 09:37:36
Also in
kvm, linux-arm-kernel, linux-arm-msm, linux-iommu, netdev, virtualization
Reply to
Will Deacon, 2021-03-30
On Tue, Mar 30, 2021 at 01:58:17PM +0100, Will Deacon wrote:
pamu_config_ppaace() takes quite a few useless parameters at this stage,
but anyway:
I'll see it it makes sense to throw in another patch at the end to cut
it down a bit more.
Acked-by: Will Deacon <will@kernel.org>

Do you know if this driver is actually useful? Once the complexity has been
stripped back, the stubs and default values really stand out.
Yeah.  No idea what the usefulness of this driver is.  Bascially all it
seems to do is to setup a few registers to allow access to the whole
physical memory.  But maybe that is required on this hardware to allow
for any DMA access?
Thread (51 messages) 51 messages, 3 authors, last reply 2021-04-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help