Re: [PATCH 06/18] iommu/fsl_pamu: remove ->domain_window_enable

From
Christoph Hellwig <hch@lst.de>
Date
2021-04-01 09:32:47
Also in
kvm, linux-arm-kernel, linux-arm-msm, linux-iommu, netdev, virtualization
Reply to
Will Deacon, 2021-03-30
On Tue, Mar 30, 2021 at 01:40:09PM +0100, Will Deacon wrote:
quoted
+	ret = pamu_config_ppaace(liodn, geom->aperture_start,
+				 geom->aperture_end - 1, ~(u32)0,
You're passing 'geom->aperture_end - 1' as the size here, but the old code
seemed to _add_ 1:
quoted
-	win_size = (domain->geometry.aperture_end + 1) >> ilog2(1);
here ^^ when calculating the exclusive upper bound. In other words, I think
'1ULL << 36' used to get passed to pamu_config_ppaace(). Is that an
intentional change?
No, I've fixed it up.
Thread (51 messages) 51 messages, 3 authors, last reply 2021-04-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help