Re: [PATCH net-next v4 2/2] of: net: fix of_get_mac_addr_nvmem() for non-platform devices

From
Michael Walle <hidden>
Date
2021-04-28 08:09:40
Also in
linux-amlogic, linux-devicetree, linux-mediatek, linux-omap, linux-renesas-soc, linux-staging, linux-wireless, lkml, netdev
Reply to
Benjamin Herrenschmidt, 2021-04-27
Am 2021-04-27 01:44, schrieb Benjamin Herrenschmidt:
On Mon, 2021-04-26 at 12:54 +0200, Michael Walle wrote:
quoted
(2) What do you think of eth_get_mac_address(ndev). That is, the
Not sure what you mean, eth_platform_get_mac_address() takes the
address as an argument. I think what you want is a consolidated
nvmem_get_mac_address + eth_platform_get_mac_address that takes a
device, which would have no requirement of the bus_type at all.
Sure. What I meant was the following:

 eth_get_mac_address(struct net_device *ndev)
vs.
 eth_get_mac_address(struct device *dev, u8 *mac_buf)

The first would assume the destination is ndev->dev_addr (which
is true for most of the calls, but not all).

-michael
Thread (12 messages) 12 messages, 5 authors, last reply 2021-04-28
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help