Re: [PATCH printk v2 2/5] printk: remove safe buffers
From: Sergey Senozhatsky <senozhatsky@chromium.org>
Date: 2021-04-02 02:14:33
Also in:
kexec, lkml
From: Sergey Senozhatsky <senozhatsky@chromium.org>
Date: 2021-04-02 02:14:33
Also in:
kexec, lkml
On (21/04/01 16:17), Petr Mladek wrote:
quoted
For the long term, we should introduce a printk-context API that allows callers to perfectly pack their multi-line output into a single entry. We discussed [0][1] this back in August 2020.We need a "short" term solution. There are currently 3 solutions: 1. Keep nmi_safe() and all the hacks around. 2. Serialize nmi_cpu_backtrace() by a spin lock and later by the special lock used also by atomic consoles. 3. Tell complaining people how to sort the messed logs.
Are we talking about nmi_cpu_backtrace()->dump_stack() or some other path? dump_stack() seems to be already serialized by `dump_lock`. Hmm, show_regs() is not serialized, seems like it should be under the same `dump_lock` as dump_stack().