Re: [RFC PATCH 3/8] powerpc/head-64: do less gas-specific stuff with sections
flat view
From: Nicholas Piggin <npiggin@gmail.com>
Date: 2021-03-19 01:36:00
Excerpts from Daniel Axtens's message of February 25, 2021 1:10 pm:
Reopening the section without specifying the same flags breaks the llvm integrated assembler. Don't do it: just specify all the flags all the time.
I don't have a problem with this but llvm might want to track the issue if it aims to be compatible with gas if you haven't alread opened an issue. When you fix the patch (perhaps add a quick comment as well?), then Acked-by: Nicholas Piggin <npiggin@gmail.com> Thanks, Nick
quoted hunk ↗ jump to hunk
Signed-off-by: Daniel Axtens <redacted> --- arch/powerpc/include/asm/head-64.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)diff --git a/arch/powerpc/include/asm/head-64.h b/arch/powerpc/include/asm/head-64.h index 4cb9efa2eb21..7d8ccab47e86 100644 --- a/arch/powerpc/include/asm/head-64.h +++ b/arch/powerpc/include/asm/head-64.h@@ -15,10 +15,10 @@ .macro define_data_ftsec name .section ".head.data.\name\()","a",@progbits .endm -.macro use_ftsec name - .section ".head.text.\name\()" -.endm - +//.macro use_ftsec name +// .section ".head.text.\name\()" +//.endm +#define use_ftsec define_ftsec /* * Fixed (location) sections are used by opening fixed sections and emitting * fixed section entries into them before closing them. Multiple fixed sections-- 2.27.0