Re: [PATCH v2 05/37] KVM: PPC: Book3S HV: Ensure MSR[ME] is always set in guest MSR
flat view
From: Daniel Axtens <hidden>
Date: 2021-02-26 06:07:11
Hi Nick,
quoted hunk ↗ jump to hunk
void kvmppc_set_msr_hv(struct kvm_vcpu *vcpu, u64 msr) { + /* + * Guest must always run with machine check interrupt + * enabled. + */ + if (!(msr & MSR_ME)) + msr |= MSR_ME;
This 'if' is technically redundant but you mention a future patch warning on !(msr & MSR_ME) so I'm holding off on any judgement about the 'if' until I get to that patch :) The patch seems sane to me, I agree that we don't want guests running with MSR_ME=0 and kvmppc_set_msr_hv already ensures that the transactional state is sane so this is another sanity-enforcement in the same sort of vein. All up: Reviewed-by: Daniel Axtens <redacted> Kind regards, Daniel
+ /* * Check for illegal transactional state bit combination * and if we find it, force the TS field to a safe state. -- 2.23.0