Re: [PATCH 03/13] livepatch: refactor klp_init_object

On Wed, Jan 27, 2021 at 01:58:21PM +0100, Petr Mladek wrote:

quoted

--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c

@@ -54,9 +54,6 @@ static void klp_find_object_module(struct klp_object *obj)
 {
 	struct module *mod;
 
-	if (!klp_is_module(obj))
-		return;
-

We need to either update the function description or keep this check.

I prefer to keep the check. The function does the right thing also
for the object "vmlinux". Also the livepatch code includes many
similar paranoid checks that makes the code less error prone
against any further changes.

Well, the check is in the caller now where we have a conditional for
it.  So I'd be tempted to either update the comment, or just drop the
patch.