On Wed, Jan 20, 2021 at 08:23:59AM -0600, Rob Herring wrote:

On Wed, Jan 20, 2021 at 4:53 AM Michael Walle [off-list ref] wrote:

quoted

fw_devlink will defer the probe until all suppliers are ready. We can't
use builtin_platform_driver_probe() because it doesn't retry after probe
deferral. Convert it to builtin_platform_driver().

If builtin_platform_driver_probe() doesn't work with fw_devlink, then
shouldn't it be fixed or removed? Then we're not fixing drivers later
when folks start caring about deferred probe and devlink.

I'd really prefer if we convert this to a module instead. (And all the
other PCI host drivers.)

quoted

Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default")

This happened!?

It's in linux-next in my tree, but is looking like it might be reverted
soon.  But finding these issues is good.

thanks,

greg k-h