Re: [PATCH] ALSA: ppc: remove redundant checks in PS3 driver probe
From: Takashi Iwai <hidden>
Date: 2020-11-28 08:53:21
Also in:
alsa-devel
From: Takashi Iwai <hidden>
Date: 2020-11-28 08:53:21
Also in:
alsa-devel
On Fri, 27 Nov 2020 16:22:59 +0100, Leonard Goehrs wrote:
The check for the FW_FEATURE_PS3_LV1 firmware feature is already performed in ps3_system_bus_init() before registering the driver. So if the probe function is actually used, this feature is already known to be available. The check for the match id is also superfluous; the condition is always true because the bus' match function (ps3_system_bus_match()) only considers this driver for devices having: dev->match_id == snd_ps3_bus_driver_info.match_id. Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Leonard Goehrs <l.goehrs@pengutronix.de>
Applied now. Thanks. Takashi