Thread (18 messages) 18 messages, 7 authors, 2020-12-10

Re: [PATCH 2/2] powerpc/ps3: make system bus's remove and shutdown callbacks return void

From: Uwe Kleine-König <hidden>
Date: 2020-11-29 17:34:07
Also in: alsa-devel, dri-devel, linux-block, linux-fbdev, linux-scsi, linux-usb, netdev

Hello Michael,

On Sat, Nov 28, 2020 at 09:48:30AM +0100, Takashi Iwai wrote:
On Thu, 26 Nov 2020 17:59:50 +0100,
Uwe Kleine-König wrote:
quoted
The driver core ignores the return value of struct device_driver::remove
because there is only little that can be done. For the shutdown callback
it's ps3_system_bus_shutdown() which ignores the return value.

To simplify the quest to make struct device_driver::remove return void,
let struct ps3_system_bus_driver::remove return void, too. All users
already unconditionally return 0, this commit makes it obvious that
returning an error code is a bad idea and ensures future users behave
accordingly.

Signed-off-by: Uwe Kleine-König <redacted>
For the sound bit:
Acked-by: Takashi Iwai <redacted>
assuming that you are the one who will apply this patch: Note that it
depends on patch 1 that Takashi already applied to his tree. So you
either have to wait untils patch 1 appears in some tree that you merge
before applying, or you have to take patch 1, too. (With Takashi
optinally dropping it then.)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help