Re: [PATCH 00/15] selftests/seccomp: Refactor change_syscall()
From: Kees Cook <hidden>
Date: 2020-09-14 20:33:11
Also in:
linux-arm-kernel, linux-kselftest, linux-mips, lkml
On Mon, Sep 14, 2020 at 10:15:18PM +1000, Michael Ellerman wrote:
Kees Cook [off-list ref] writes:quoted
Hi, This refactors the seccomp selftest macros used in change_syscall(), in an effort to remove special cases for mips, arm, arm64, and xtensa, which paves the way for powerpc fixes. I'm not entirely done testing, but all-arch build tests and x86_64 selftests pass. I'll be doing arm, arm64, and i386 selftests shortly, but I currently don't have an easy way to check xtensa, mips, nor powerpc. Any help there would be appreciated!The series builds fine for me, and all the tests pass (see below). Thanks for picking up those changes to deal with powerpc being oddball. Tested-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
Awesome; thanks! However...
cheers ./seccomp_bpf TAP version 13 1..86 # Starting 86 tests from 7 test cases. # RUN global.kcmp ... # OK global.kcmp ok 1 global.kcmp [...] # RUN global.KILL_thread ... TAP version 13 1..86 # Starting 86 tests from 7 test cases.
Was this a mis-paste, or has something very very bad happened here in global.KILL_one_arg_six finishes?
# RUN global.kcmp ... # OK global.kcmp ok 1 global.kcmp [...] # RUN global.user_notification_basic ... TAP version 13 1..86 # Starting 86 tests from 7 test cases. [...] # RUN global.user_notification_basic ... TAP version 13 1..86 # Starting 86 tests from 7 test cases. [...] # RUN global.user_notification_signal ... TAP version 13 1..86 # Starting 86 tests from 7 test cases. [...] # RUN global.user_notification_closed_listener ... TAP version 13 1..86 # Starting 86 tests from 7 test cases. [...] # RUN global.user_notification_child_pid_ns ... TAP version 13 1..86 # Starting 86 tests from 7 test cases. [...] # RUN global.user_notification_sibling_pid_ns ... TAP version 13 1..86 # Starting 86 tests from 7 test cases. [...] # RUN global.user_notification_sibling_pid_ns ... TAP version 13 1..86 # Starting 86 tests from 7 test cases. [...] # RUN global.user_notification_sibling_pid_ns ... TAP version 13 1..86 # Starting 86 tests from 7 test cases. [...] # RUN global.user_notification_fault_recv ... TAP version 13 1..86 # Starting 86 tests from 7 test cases. [...] # RUN global.user_notification_continue ... TAP version 13 1..86 # Starting 86 tests from 7 test cases. [...] # RUN global.user_notification_filter_empty ... TAP version 13 1..86 # Starting 86 tests from 7 test cases. [...] # RUN global.user_notification_filter_empty_threaded ... TAP version 13 1..86 # Starting 86 tests from 7 test cases. [...] # RUN global.user_notification_addfd ... TAP version 13 1..86 # Starting 86 tests from 7 test cases. [...] # RUN global.user_notification_addfd_rlimit ... TAP version 13 1..86 # Starting 86 tests from 7 test cases. [...] # PASSED: 86 / 86 tests passed. # Totals: pass:86 fail:0 xfail:0 xpass:0 skip:0 error:0
And after every user_notification test? O_O -- Kees Cook