Re: [PATCH 05/13] cpufreq/arch: powerpc: pasemi: Move prototypes to shared header
From: Viresh Kumar <viresh.kumar@linaro.org>
Date: 2020-07-15 03:51:32
Also in:
linux-arm-kernel, linux-pm, lkml
On 14-07-20, 20:49, Olof Johansson wrote:
quoted hunk ↗ jump to hunk
On Tue, Jul 14, 2020 at 8:07 PM Viresh Kumar [off-list ref] wrote:quoted
On 14-07-20, 15:50, Lee Jones wrote:quoted
If function callers and providers do not share the same prototypes the compiler complains of missing prototypes. Fix this by moving the already existing prototypes out to a mutually convenient location. Fixes the following W=1 kernel build warning(s): drivers/cpufreq/pasemi-cpufreq.c:109:5: warning: no previous prototype for ‘check_astate’ [-Wmissing-prototypes] 109 | int check_astate(void) | ^~~~~~~~~~~~ drivers/cpufreq/pasemi-cpufreq.c:114:6: warning: no previous prototype for ‘restore_astate’ [-Wmissing-prototypes] 114 | void restore_astate(int cpu) | ^~~~~~~~~~~~~~ Cc: Olof Johansson <redacted> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Paul Mackerras <redacted> Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones <redacted> --- arch/powerpc/platforms/pasemi/pasemi.h | 15 ------------Is there no sane way we can include this file directly to the cpufreq file ?Yep. arch/powerpc seems to be in the search path for modules on powerpc, so:diff --git a/drivers/cpufreq/pasemi-cpufreq.c b/drivers/cpufreq/pasemi-cpufreq.c index c66f566a854cb..815645170c4de 100644 --- a/drivers/cpufreq/pasemi-cpufreq.c +++ b/drivers/cpufreq/pasemi-cpufreq.c@@ -22,6 +22,8 @@ #include <asm/time.h> #include <asm/smp.h> +#include <platforms/pasemi/pasemi.h> + #define SDCASR_REG 0x0100 #define SDCASR_REG_STRIDE 0x1000 #define SDCPWR_CFGA0_REG 0x0100
Fantastic. Thanks. -- viresh