Thread (5 messages) flat view 5 messages, 2 authors, 2020-06-23

Re: [PATCH v2 1/2] ASoC: fsl_mqs: Don't check clock is NULL before calling clk API

From: Shengjiu Wang <shengjiu.wang@gmail.com>
Date: 2020-06-23 08:32:16
Also in: alsa-devel, kernel-janitors, lkml

On Tue, Jun 23, 2020 at 3:38 PM Markus Elfring [off-list ref] wrote:
quoted
In-Reply-To: [ref]
I guess that it should be sufficient to specify such a field once
for the header information.
seems it's caused by my "git format-patch" command, I will update
it, hope it is better next time.
quoted
Because clk_prepare_enable and clk_disable_unprepare should
check input clock parameter is NULL or not internally,
I find this change description unclear.
    clk_prepare_enable and clk_disable_unprepare check the input
    clock parameter in the beginning of the function, if the parameter
    is NULL, clk_prepare_enable and clk_disable_unprepare will
    return immediately.

    So Don't need to check input clock parameters before calling clk
    API.

Do you think this commit message is better?

best regards
wang shengjiu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help