Thread (5 messages) flat view 5 messages, 2 authors, 2020-06-23

Re: [PATCH v2 1/2] ASoC: fsl_mqs: Don't check clock is NULL before calling clk API

From: Markus Elfring <hidden>
Date: 2020-06-23 07:37:13
Also in: alsa-devel, kernel-janitors, lkml

In-Reply-To: [ref]
I guess that it should be sufficient to specify such a field once
for the header information.

Because clk_prepare_enable and clk_disable_unprepare should
check input clock parameter is NULL or not internally,
I find this change description unclear.

then we don't need to check them before calling the function.
Please use an imperative wording for the commit message.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=dd0d718152e4c65b173070d48ea9dfc06894c3e5#n151

Regards,
Markus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help