Thread (66 messages) 66 messages, 6 authors, 2020-04-15

Re: [PATCH v5 05/21] powerpc: Use a function for getting the instruction op code

From: Jordan Niethe <hidden>
Date: 2020-04-09 04:50:34

On Thu, Apr 9, 2020 at 4:21 AM Segher Boessenkool
[off-list ref] wrote:
Hi!

On Mon, Apr 06, 2020 at 06:09:20PM +1000, Jordan Niethe wrote:
quoted
+static inline int ppc_inst_opcode(u32 x)
+{
+     return x >> 26;
+}
Maybe you should have "primary opcode" in this function name?
Thanks, that is a good idea.

Segher
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help