Re: [PATCH v5 09/21] powerpc: Use a datatype for instructions

Hi Jordan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v5.6]
[cannot apply to powerpc/next kvm-ppc/kvm-ppc-next scottwood/next next-20200406]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Jordan-Niethe/Initial-Prefixed-Instruction-support/20200406-165215
base:    7111951b8d4973bda27ff663f2cf18b663d15b48
config: powerpc-rhel-kconfig (attached as .config)
compiler: powerpc64le-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.3.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <redacted>

All errors (new ones prefixed by >>):

   arch/powerpc/lib/feature-fixups.c: In function 'do_final_fixups':

quoted

arch/powerpc/lib/feature-fixups.c:404:25: error: passing argument 1 of 'raw_patch_instruction' from incompatible pointer type [-Werror=incompatible-pointer-types]

     404 |   raw_patch_instruction(dest, ppc_inst(*src));
         |                         ^~~~
         |                         |
         |                         int *
   In file included from arch/powerpc/lib/feature-fixups.c:18:
   arch/powerpc/include/asm/code-patching.h:32:44: note: expected 'struct ppc_inst *' but argument is of type 'int *'
      32 | int raw_patch_instruction(struct ppc_inst *addr, struct ppc_inst instr);
         |                           ~~~~~~~~~~~~~~~~~^~~~
   cc1: some warnings being treated as errors

vim +/raw_patch_instruction +404 arch/powerpc/lib/feature-fixups.c

2d1b2027626d51 Kumar Gala             2008-07-02  389  
9402c684613163 Benjamin Herrenschmidt 2016-07-05  390  static void do_final_fixups(void)
d715e433b7ad19 Anton Blanchard        2011-11-14  391  {
d715e433b7ad19 Anton Blanchard        2011-11-14  392  #if defined(CONFIG_PPC64) && defined(CONFIG_RELOCATABLE)
d715e433b7ad19 Anton Blanchard        2011-11-14  393  	int *src, *dest;
d715e433b7ad19 Anton Blanchard        2011-11-14  394  	unsigned long length;
d715e433b7ad19 Anton Blanchard        2011-11-14  395  
d715e433b7ad19 Anton Blanchard        2011-11-14  396  	if (PHYSICAL_START == 0)
d715e433b7ad19 Anton Blanchard        2011-11-14  397  		return;
d715e433b7ad19 Anton Blanchard        2011-11-14  398  
d715e433b7ad19 Anton Blanchard        2011-11-14  399  	src = (int *)(KERNELBASE + PHYSICAL_START);
d715e433b7ad19 Anton Blanchard        2011-11-14  400  	dest = (int *)KERNELBASE;
d715e433b7ad19 Anton Blanchard        2011-11-14  401  	length = (__end_interrupts - _stext) / sizeof(int);
d715e433b7ad19 Anton Blanchard        2011-11-14  402  
d715e433b7ad19 Anton Blanchard        2011-11-14  403  	while (length--) {
16f7ae823ee707 Jordan Niethe          2020-04-06 @404  		raw_patch_instruction(dest, ppc_inst(*src));
d715e433b7ad19 Anton Blanchard        2011-11-14  405  		src++;
d715e433b7ad19 Anton Blanchard        2011-11-14  406  		dest++;
d715e433b7ad19 Anton Blanchard        2011-11-14  407  	}
d715e433b7ad19 Anton Blanchard        2011-11-14  408  #endif
d715e433b7ad19 Anton Blanchard        2011-11-14  409  }
d715e433b7ad19 Anton Blanchard        2011-11-14  410  

:::::: The code at line 404 was first introduced by commit
:::::: 16f7ae823ee70796c5ba2cc321b2c02f3dcfb816 powerpc: Use a macro for creating instructions from u32s

:::::: TO: Jordan Niethe [off-list ref]
:::::: CC: 0day robot [off-list ref]

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org