Re: [PATCH V12] mm/debug: Add tests validating architecture page table helpers

On 1/27/20 7:33 PM, Qian Cai wrote:

quoted

quoted

What’s the value of this block of new code? It only supports x86 and arm64
which are supposed to be good now.

We have been over the usefulness of this code many times before as the patch is
already in it's V12. Currently it is enabled on arm64, x86 (except PAE), arc and
ppc32. There are build time or runtime problems with other archs which prevent

I am not sure if I care too much about arc and ppc32 which are pretty much legacy
platforms.

You really need to brush up on your definition and knowledge of what "legacy" means.
ARC is actively maintained and used by several customers, some in arch/arc/plat*
and some not in there.
It is present in broadband routers used by major ISP, massively multicore deep
packet inspection system from EZChip, and many more....

Sure you may not care about them, but the maintainers for the platforms do.
It would have been better if you had spent the time and energy in improving the
code over 12 revisions rather than bike shedding.

-Vineet