-----Original Message-----
From: Lorenzo Pieralisi <redacted>
Sent: 2019年11月5日 20:38
To: Kishon Vijay Abraham I <redacted>
Cc: Andrew Murray <redacted>; Xiaowei Bao
[off-list ref]; gustavo.pimentel@synopsys.com;
bhelgaas@google.com; robh+dt@kernel.org; mark.rutland@arm.com;
shawnguo@kernel.org; Leo Li [off-list ref];
lorenzo.pieralisi@arm.co; arnd@arndb.de; gregkh@linuxfoundation.org; M.h.
Lian [off-list ref]; Mingkai Hu [off-list ref]; Roy
Zang [off-list ref]; jingoohan1@gmail.com;
linux-pci@vger.kernel.org; devicetree@vger.kernel.org;
linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 07/10] PCI: layerscape: Modify the MSIX to the
doorbell way

On Thu, Aug 29, 2019 at 10:43:18AM +0530, Kishon Vijay Abraham I wrote:

quoted

Gustavo,

On 27/08/19 6:55 PM, Andrew Murray wrote:

quoted

On Sat, Aug 24, 2019 at 12:08:40AM +0000, Xiaowei Bao wrote:

quoted

quoted

-----Original Message-----
From: Andrew Murray <redacted>
Sent: 2019年8月23日 21:58
To: Xiaowei Bao <redacted>
Cc: bhelgaas@google.com; robh+dt@kernel.org;

mark.rutland@arm.com;

quoted

quoted

quoted

quoted

shawnguo@kernel.org; Leo Li [off-list ref]; kishon@ti.com;
lorenzo.pieralisi@arm.co; arnd@arndb.de; gregkh@linuxfoundation.org;

M.h.

quoted

quoted

quoted

quoted

Lian [off-list ref]; Mingkai Hu [off-list ref];

Roy

quoted

quoted

quoted

quoted

Zang [off-list ref]; jingoohan1@gmail.com;
gustavo.pimentel@synopsys.com; linux-pci@vger.kernel.org;
devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
linux-arm-kernel@lists.infradead.org;
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 07/10] PCI: layerscape: Modify the MSIX to
the doorbell way

On Thu, Aug 22, 2019 at 07:22:39PM +0800, Xiaowei Bao wrote:

quoted

The layerscape platform use the doorbell way to trigger MSIX
interrupt in EP mode.

I have no problems with this patch, however...

Are you able to add to this message a reason for why you are
making this change? Did dw_pcie_ep_raise_msix_irq not work when
func_no != 0? Or did it work yet dw_pcie_ep_raise_msix_irq_doorbell is

more efficient?

quoted

quoted

quoted

The fact is that, this driver is verified in ls1046a platform of
NXP before, and ls1046a don't support MSIX feature, so I set the
msix_capable of pci_epc_features struct is false, but in other
platform, e.g. ls1088a, it support the MSIX feature, I verified the MSIX

feature in ls1088a, it is not OK, so I changed to another way. Thanks.

quoted

quoted

Right, so the existing pci-layerscape-ep.c driver never supported
MSIX yet it erroneously had a switch case statement to call
dw_pcie_ep_raise_msix_irq which would never get used.

Now that we're adding a platform with MSIX support the existing
dw_pcie_ep_raise_msix_irq doesn't work (for this platform) so we are
adding a different method.

Gustavo, can you confirm dw_pcie_ep_raise_msix_irq() works for
designware as it didn't work for both me and Xiaowei?

This question needs an answer.

This question have answered by Gustavo in "[PATCH v3 08/11] PCI: layerscape: 
Modify the MSIX to the doorbell mode", please refer to the comments, due to
add a new patch for this sets of patch, this patch number changed from 07/10 of v2
to 08/11 of v3, sorry for causing your confuse.


Thanks 
Xiaowei  

Thanks,
Lorenzo