Thread (74 messages) 74 messages, 4 authors, 2019-09-10

Re: [PATCH v5 06/31] pseries/fadump: define register/un-register callback functions

From: Hari Bathini <hbathini@linux.ibm.com>
Date: 2019-09-03 17:17:42


On 03/09/19 4:40 PM, Michael Ellerman wrote:
Hari Bathini [off-list ref] writes:
quoted
Make RTAS calls to register and un-register for FADump. Also, update
how fadump_region contents are diplayed to provide more information.
That sounds like two independent changes, so can this be split into two
patches?
Yeah. On splitting, the below hunk would look a bit different in this patch
and the split patch would change it to how it looks now:
+	seq_printf(m, "DUMP: Src: %#016llx, Dest: %#016llx, ",
+		   be64_to_cpu(fdm_ptr->rmr_region.source_address),
+		   be64_to_cpu(fdm_ptr->rmr_region.destination_address));
+	seq_printf(m, "Size: %#llx, Dumped: %#llx bytes\n",
+		   be64_to_cpu(fdm_ptr->rmr_region.source_len),
+		   be64_to_cpu(fdm_ptr->rmr_region.bytes_dumped));

- Hari
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help