Re: [PATCH v5 01/31] powerpc/fadump: move internal macros/definitions to a new header

Hari Bathini [off-list ref] writes:

Though asm/fadump.h is meant to be used by other components dealing
with FADump, it also has macros/definitions internal to FADump code.
Move them to a new header file used within FADump code. This also
makes way for refactoring platform specific FADump code.

Signed-off-by: Hari Bathini <hbathini@linux.ibm.com>
---
 arch/powerpc/include/asm/fadump.h   |   71 ----------------------------
 arch/powerpc/kernel/fadump-common.h |   89 +++++++++++++++++++++++++++++++++++
 arch/powerpc/kernel/fadump.c        |    2 +

I don't like having a header in kernel that's then used in platform
code. Because we end up having to do gross things like:

  arch/powerpc/platforms/powernv/opal-core.c:#include "../../kernel/fadump-common.h"
  arch/powerpc/platforms/powernv/opal-fadump.c:#include "../../kernel/fadump-common.h"
  arch/powerpc/platforms/pseries/rtas-fadump.c:#include "../../kernel/fadump-common.h"


I'd rather you put the internal bits in arch/powerpc/include/asm/fadump-internal.h

cheers