Re: [PATCH v4 8/8] KVM: PPC: Ultravisor: Check for MSR_S during hv_reset_msr
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2019-07-11 13:19:20
Claudio Carvalho [off-list ref] writes:
From: Michael Anderson <redacted> - Check for MSR_S so that kvmppc_set_msr will include it. Prior to this change return to guest would not have the S bit set.
That sounds like it would be bad? Please spell out what the practical impact of the patch is, ie. somewhere on the spectrum from "without this patch everything catches fire", to "this is not a bug but makes things clearer because ..." cheers
quoted hunk ↗ jump to hunk
- Patch based on comment from Paul Mackerras [off-list ref] Signed-off-by: Michael Anderson <redacted> Signed-off-by: Claudio Carvalho <redacted> Acked-by: Paul Mackerras <redacted> --- arch/powerpc/kvm/book3s_64_mmu_hv.c | 1 + 1 file changed, 1 insertion(+)diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c index ab3d484c5e2e..ab62a66f9b4e 100644 --- a/arch/powerpc/kvm/book3s_64_mmu_hv.c +++ b/arch/powerpc/kvm/book3s_64_mmu_hv.c@@ -295,6 +295,7 @@ static void kvmppc_mmu_book3s_64_hv_reset_msr(struct kvm_vcpu *vcpu) msr |= MSR_TS_S; else msr |= vcpu->arch.shregs.msr & MSR_TS_MASK; + msr |= vcpu->arch.shregs.msr & MSR_S; kvmppc_set_msr(vcpu, msr); }-- 2.20.1