Re: [PATCH v2] powerpc: slightly improve cache helpers

On Sun, Jul 21, 2019 at 12:58:46AM -0700, Nathan Chancellor wrote:

I have attached the disassembly of arch/powerpc/kernel/mem.o with
clear_page (working) and broken_clear_page (broken), along with the side
by side diff. My assembly knowledge is fairly limited as it stands and
it is certainly not up to snuff on PowerPC so I have no idea what I am
looking for. Please let me know if anything immediately looks off or if
there is anything else I can do to help out.

You might want to use a disassembler that shows most simplified mnemonics,
and you crucially should show the relocations.  "objdump -dr" works nicely.

0000017c clear_user_page:
     17c: 38 80 00 80                  	li 4, 128
     180: 7c 89 03 a6                  	mtctr 4
     184: 7c 00 1f ec                  	dcbz 0, 3
     188: 38 63 00 20                  	addi 3, 3, 32
     18c: 42 00 ff f8                  	bdnz .+65528

That offset is incorrectly disassembled, btw (it's a signed field, not
unsigned).

0000017c clear_user_page:
     17c: 94 21 ff f0                  	stwu 1, -16(1)
     180: 38 80 00 80                  	li 4, 128
     184: 38 63 ff e0                  	addi 3, 3, -32
     188: 7c 89 03 a6                  	mtctr 4
     18c: 38 81 00 0f                  	addi 4, 1, 15
     190: 8c c3 00 20                  	lbzu 6, 32(3)
     194: 98 c1 00 0f                  	stb 6, 15(1)
     198: 7c 00 27 ec                  	dcbz 0, 4
     19c: 42 00 ff f4                  	bdnz .+65524

Uh, yeah, well, I have no idea what clang tried here, but that won't
work.  It's copying a byte from each target cache line to the stack,
and then does clears the cache line containing that byte on the stack.

I *guess* this is about "Z" and not about "%y", but you'll have to ask
the clang people.

Or it may be that they do not treat inline asm operands as lvalues
properly?  That rings some bells.  Yeah that looks like it.


Segher